Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE and tests using flit #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
22 changes: 22 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
[build-system]
requires = ["flit_core >=2,<4"]
build-backend = "flit_core.buildapi"


[tool.flit.metadata]
module = "sphinxext_opengraph"
author = "Itay Ziv"
author-email = "[email protected]"
home-page = "https://github.com/wpilibsuite/sphinxext-opengraph"
description-file = "README.md"
requires-python = ">=3.6"
requires = ["sphinx >= 2"]

# [tool.flit.metadata.requires-extra]
# test = [
# "conftest.py",
# "roots",
# "test_options.py"

# ]
# doc = ["
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
long_description=long_description,
long_description_content_type="text/markdown",
url="https://github.com/wpilibsuite/sphinxext-opengraph",
license="LICENSE.md",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this inconsistent with renaming from LICENSE.md to LICENSE

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's a leftover from an earlier version (it's the first time I have to create a python package)

install_requires=["sphinx>=2.0"],
packages=["sphinxext/opengraph"],
classifiers=[
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"""Sphinx extension to generate OpenGraph metadata (https://ogp.me/)"""

from typing import Any, Dict
from urllib.parse import urljoin, urlparse, urlunparse
from pathlib import Path, PosixPath
Expand All @@ -11,6 +13,7 @@

import os

__version__ = "0.4.2"

DEFAULT_DESCRIPTION_LENGTH = 200

Expand Down