Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network tables #815

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Fix network tables #815

merged 6 commits into from
Nov 13, 2024

Commits on Oct 26, 2024

  1. Fix NT tab generation

    Was relying on the main plugin's subscribe-all behavior
    SamCarlberg committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    9e57264 View commit details
    Browse the repository at this point in the history
  2. Prioritize .type NT metadata events

    Prevents data type issues where topic ordering is nondeterministic and type information could arrive after sources are set up
    SamCarlberg committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    1ea78d7 View commit details
    Browse the repository at this point in the history
  3. Fit NT type lookup

    Was based on NT table structures, which weren't returning correct data
    SamCarlberg committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    b636afc View commit details
    Browse the repository at this point in the history
  4. Handle non-normalized topic names

    Shuffleboard historically relied on the assumption that a leading slash was optional for paths in networktables. NT4 changed that by making topic names exact (so two topic names only differing by the presence or absence of a leading slash would be two unique topics), which broke NT data sources for topics without leading slashes
    SamCarlberg committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    de08b0d View commit details
    Browse the repository at this point in the history
  5. Linting

    SamCarlberg committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    dcea59f View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Remove unnecessary sendAll from NT tab generator code

    We don't write to the metadata topics, it's all sent over from the server
    SamCarlberg committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    5b4b3b9 View commit details
    Browse the repository at this point in the history