More PMD fixes

wpilibsuite · Feb 17, 2024 · 533bfe8 · 533bfe8
1 parent 50245fa
commit 533bfe8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.../edu/wpi/first/shuffleboard/plugin/networktables/sources/CompositeNetworkTableSource.java b/.../edu/wpi/first/shuffleboard/plugin/networktables/sources/CompositeNetworkTableSource.java
@@ -2,7 +2,6 @@
 
 import edu.wpi.first.shuffleboard.api.data.ComplexData;
 import edu.wpi.first.shuffleboard.api.data.ComplexDataType;
-import edu.wpi.first.shuffleboard.api.data.DataTypes;
 import edu.wpi.first.shuffleboard.api.data.IncompleteDataException;
 import edu.wpi.first.shuffleboard.api.sources.Sources;
 import edu.wpi.first.shuffleboard.plugin.networktables.util.NetworkTableUtils;

diff --git a/.../java/edu/wpi/first/shuffleboard/plugin/networktables/sources/NetworkTableSourceType.java b/.../java/edu/wpi/first/shuffleboard/plugin/networktables/sources/NetworkTableSourceType.java
@@ -25,14 +25,15 @@
 import javafx.collections.ObservableList;
 import javafx.collections.ObservableMap;
 
-public final class NetworkTableSourceType extends SourceType {
+public final class NetworkTableSourceType extends SourceType implements AutoCloseable {
 
   private static NetworkTableSourceType instance;
 
   private final ObservableList<String> availableSourceIds = FXCollections.observableArrayList();
   private final ObservableMap<String, Object> availableSources = FXCollections.observableHashMap();
   private final NetworkTablesPlugin plugin;
   private final MultiSubscriber subscriber;
+  private final int listener;
 
   @SuppressWarnings("JavadocMethod")
   public NetworkTableSourceType(NetworkTablesPlugin plugin) {
@@ -77,6 +78,12 @@ public NetworkTableSourceType(NetworkTablesPlugin plugin) {
         });
   }
 
+  @Override
+  public void close() {
+    subscriber.close();
+    NetworkTableInstance.getDefault().removeListener(listener);
+  }
+
   private void setConnectionStatus(String serverId, boolean connected) {
     Platform.runLater(() -> {
       String host;