Skip to content

Fix jvm-runtime.rst #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix jvm-runtime.rst #2987

merged 1 commit into from
Jun 2, 2025

Conversation

arimb
Copy link
Contributor

@arimb arimb commented Feb 23, 2025

add missing space in code snippet

add missing space in code snippet
@PeterJohnson
Copy link
Member

PeterJohnson commented Feb 23, 2025

A space is not required here (between -D and the option), and various examples I’ve seen online don’t include one, e.g. https://docs.gradle.org/current/userguide/build_environment.html#setting_a_system_property

@arimb
Copy link
Contributor Author

arimb commented Feb 23, 2025

Strange, it didn't work for me when I used it as written but did work when I added a space. Maybe it's only needed in certain terminals

@sciencewhiz
Copy link
Collaborator

Both versions appear to work in CMD, but only the one with a space appears to work in powershell

@sciencewhiz sciencewhiz merged commit 3b16e13 into wpilibsuite:main Jun 2, 2025
10 checks passed
@arimb arimb deleted the patch-1 branch June 2, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants