Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same variable name between two code blocks on the same SysID page #2533

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Use same variable name between two code blocks on the same SysID page #2533

merged 1 commit into from
Jan 17, 2024

Conversation

Anhysteretic
Copy link
Contributor

The two code blocks use two different variable names for the SysIdRoutine, adjust the naming to be the same variable to reduce confusion for readers.

The two code blocks use two different variable names for the SysIdRoutine, adjust the naming to be the same variable to reduce confusion for readers.
@Anhysteretic Anhysteretic changed the title Use same variable name between the two code blocks Use same variable name between two code blocks on the same SysID page Jan 17, 2024
@sciencewhiz sciencewhiz changed the base branch from stable to main January 17, 2024 04:53
@sciencewhiz
Copy link
Collaborator

Per https://docs.wpilib.org/en/latest/docs/contributing/frc-docs/contribution-guidelines.html#creating-a-pr PRs should be created against the main branch, not stable. I changed the branch to main.

@sciencewhiz sciencewhiz merged commit 75dd8e6 into wpilibsuite:main Jan 17, 2024
11 checks passed
@Anhysteretic Anhysteretic deleted the patch-1 branch January 17, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants