-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to sphinx 7 #2360
Update to sphinx 7 #2360
Conversation
Unfortunately, It's fairly common for things to break on big upgrades like this in the past. Here's what I've noticed:
I'm not sure if there's a way to see if translations or pdf/html still works without merging @Daltz333 |
You can build translations locally to test, but I'd just rely on CI to test PDF builds. |
Looks like translations failed |
wpilibsuite/frc-docs-translations#36 should fix the translations |
The colors on the front panels seem back to normal |
Needs a rebase |
Rebased and builds succeeding. |
The readthedocs build broke. https://readthedocs.org/projects/frc-docs/builds/22522908/ This reverts commit 7004782.
The readthedocs build broke. https://readthedocs.org/projects/frc-docs/builds/22522908/ This reverts commit 7004782.
@sciencewhiz Strange that it failed. I can repro the problem locally by running the command that rtd runs for whatever part of the build it is that failed. However, I can't figure out where the problem is as the stack trace is fairly unhelpful. |
@TheTripleV identified the problem as being from https://github.com/wpilibsuite/frc-docs/blob/main/source/_extensions/rtd_patch.py |
Adding |
Fixed PR in #2395 |
Currently first pass