Switch Theme To Furo #2626
Switch Theme To Furo #2626
Conversation
|
I think @Daltz333 might be the best judge if and how this change could be made. As is there are multiple things I don't like about the current implementation:
Overall I like many of the features this brings I think we just need to have a deeper discussion on many of the "fine" points. |
Check out the sidebar changes I just pushed. It looks way better to me. The rest I'd like to get some more opinions before changing, as I've heard very different takes on them from different people. |
|
On the topic of looks, the people who's opinion matters most are @Kevin-OConnor (FiRST) and @arbessette (WPI). I suspect they're both busy until after championships. |
|
Yep, pretty swamped through Champs and recovering the week after. Just set myself a calendar notification for the 29th to look at this. Sorry for the delay! |
|
Overall I think this looks much better than when I first looked at it. Couple comments:
I like the "On this page" mini table of contents that's part of this. I like the larger text size for the title, I think it helps convey the hierarchy a little better, the text sizes are pretty close between titles and various heading levels in the current theme. |
It doesn't look particularly weird to me on my laptop, but I can see how it would to others/on different resolutions. I'm not entirely sure how to fix this either- we could reduce the padding, but I feel like that might look worse.
I can definitely change colors. Which color specifically?
|
|
@Kevin-OConnor I changed the sidebar so that it takes up less space. Does that look better? I'm still unsure which teal color you mean exactly. (re:
|
LGTM. The colors of all the header blocks on the home page are the ones that don't seem to match the color scheme to me but I'm good with merging this and worrying about that later. |
|
Lets wait to merge until we split stable and main (so we can fix any issues that emerge without back-porting). |
|
Before merging I would like to get somebody who understands one of the RTL language(s?) to make sure I didn't break anything in the change. I tried to keep everything looking like it did on the old version, but it is very possible that I missed something. |
|
|
Is there a way to build the Hebrew translation with the changes here? I can see if it's broken, but I'm not familiar enough with RTD/CSS/etc to know in advance. |
here you go: https://he.grahamsh.com/ |
| @@ -31,9 +31,10 @@ def do(app: Sphinx, exception: Union[Exception, None]) -> None: | |||
| print("Running custom post processing") | |||
|
|
|||
| # The two fontawesome functions must run in order | |||
| cleanup_fontawesome_css(app) | |||
| cleanup_fontawesome_font_files(app) | |||
| switch_to_system_fonts(app) | |||
There was a problem hiding this comment.
Does furo use system fonts by default?
|
@GrahamSH-LLK thanks for the build! Some panel buttons on the homepage lost the framed link: The headings sidebar opens properly, but the TOC sidebar doesn't open. Another note (not only RTL), I'm not sure I'm a fan of the blockquoting here: This might be a problem in the source itself (note the difference in capitalization of the language labels):
|
Believe it or not, those buttons seem to be missing on stable Hebrew too. I'm not sure if this is intentional, but it's not a regression in this PR.
That was just fixed (see https://he.grahamsh.com)
What do you dislike exactly?
That must be a mistake from an earlier PR of mine where sphinx tabs were migrated. I'll send a PR to make it consistent soon. |
|
|
Buttons: bummer it's an upstream limitation, but oh well. TOC sidebar: fixed; thanks! Changelog blockquote: I'm not entirely a fan of the seemingly-arbitrary blockquoting of nested lists. Why not keep it without blockquotes? Just seems a bit weird imo that part of the changelog is quoted and some isn't, but it's probably a matter of taste so I won't object. Tab labels: sounds good. Overall, LGTM! |
removed. |
I agree, that looks weird. That doesn't happen here with nested lists: https://sphinx-themes.org/sample-sites/furo/kitchen-sink/lists/ |
|
This is why: pradyunsg/furo#190 Should probably find places with 4 space indents and fix, seems like it could show up many places. |
|
There's conflicts to resolve |
|
The interactive pid tuning is broken |
|
The js files are being added to the html past the content, so they're not available at the js entrypoint in the article. Wrapping the entrypoint in a <script>
addEventListener("load", (event) => {
flywheel_pid = new FlywheelPIDF("flywheel_feedforward", "feedforward");
});
</script> |
|
Depends on pradyunsg/furo#795 |
|
Depends on #2729 |
|
What is sphinx-build-compatibility needed for? |
It injects the variables into sphinx that RTD used to add that Furo relies on for features such as the GitHub edit button. It's the advised workaround for the issue you linked above. The one thing I haven't done is fix the blockquoting- like you said in #2729, it's a tricky issue to fix-- a naive find and replace shouldn't work. Any ideas? |
|
We already inject the things needed for the GitHub edit button (at least for the rtd theme), as well as for the delta extension. That's why I'm wondering what additional is needed from that, as well as whether that would overwrite what we inject. |
RTD theme is up to date with the RTD migration, Furo isn't yet. Without this change, it was missing the edit button integration. |
It turns out 3/4 spaces was not the main cause. I searched the generated html for the blockquote tag and started fixing them in #2853. So far the two categories I found were lists with any amount of indent, and nested lists where there was a blank line between items. |
Furo