Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 4 space indents to 3 spaces to fix formatting for Furo #2729

Closed
sciencewhiz opened this issue Sep 6, 2024 · 2 comments
Closed

Change 4 space indents to 3 spaces to fix formatting for Furo #2729

sciencewhiz opened this issue Sep 6, 2024 · 2 comments

Comments

@sciencewhiz
Copy link
Collaborator

Per the style guide, all indents should be 3 spaces, but there are many places where 4 spaces are used for indent. 4 spaces means blockqote in rst (https://restructuredtext.readthedocs.io/en/latest/rst_guide.html). The current theme doesn't style blockquotes that way, but furo does, so the places with 4 spaces aren't rendered as intended with furo, so this blocks #2626

I think this is more complicated then a simple find and replace, because we don't want to change spacing within code blocks. There's also places where there's ambiguities. Is 12 spaces 3 sets of 4 space indents or 4 sets of 3 space indents. You can only tell by looking at the context.

@jasondaming
Copy link
Member

Can you give examples of on what pages you see this problem on the Furo PR? I wasn't seeing them.

@sciencewhiz
Copy link
Collaborator Author

This is not the root cause of at least most of the block quotes in furo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants