Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for inlining of ChassisSpeeds transformation methods #7418

Closed
wants to merge 3 commits into from
Closed

Allow for inlining of ChassisSpeeds transformation methods #7418

wants to merge 3 commits into from

Conversation

TheComputer314
Copy link

@TheComputer314 TheComputer314 commented Nov 21, 2024 •
edited
Loading

a3b12b3 made ChassisSpeeds.discretize(), ChassisSpeeds.toRobotRelative(), and ChassisSpeeds.toFieldRelative() instance methods. However, the new instance methods cannot be chained, as they are void methods. This changes the 3 methods to return the ChassisSpeeds object for chaining.

@TheComputer314 TheComputer314 requested a review from a team as a code owner November 21, 2024 17:33
@TheComputer314
Copy link
Author

This makes ChassisSpeeds a mutable API and not immutable, which is undesired. (see: #7113 and #7115)

@TheComputer314 TheComputer314 deleted the ChassisSpeedsChaining branch November 21, 2024 17:42
@mjansen4857 mjansen4857 mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TheComputer314