[cmd] Fix proxy command deprecation docs

[spacey-sooty]

No description provided.

[github-actions]

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

[rzblue]

C++ has another constructor that needs changed

[spacey-sooty]

/format

[spacey-sooty]

CI failure seems to be unrelated.

[spacey-sooty]

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

Not applicable to python, the deprecation message is different.

[rzblue]

Just remembered, the other thing that needs fixed is the docs for Commands.deferredProxy

[spacey-sooty]

I'd be inclined to undeprecate deferred proxy and leave it with the new implementation. I feel it accurately describes what its syntactic sugar over

[KangarooKoala]

Why not use "proxy a deferred command" in the C++ docs like we do in Java? (Also, while we're here, it might be nice to link to command factories in adddition to the command class)

[spacey-sooty]

Why not use "proxy a deferred command" in the C++ docs like we do in Java?

You'll notice this updates the Java documentation as well, that documentation was wrong and did not give the correct behaviour. This change corrects it to give accurate behaviour

(Also, while we're here, it might be nice to link to command factories in adddition to the command class)

Yes I plan to do this but I'll also have to undeprecate deferredProxy first :)

[KangarooKoala]

Why not use "proxy a deferred command" in the C++ docs like we do in Java?

You'll notice this updates the Java documentation as well, that documentation was wrong and did not give the correct behaviour. This change corrects it to give accurate behaviour

Sorry I got the order wrong when writing on mobile, but the changed Java docs say "defer a proxy command", not "use defer command on a proxy command". Regardless of which one we use, it should be consistent between Java and C++. (And my vote is for the Java version since it's less tied to the particular command types)