Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Windows symbols #7139

Closed
virtuald opened this issue Sep 29, 2024 · 1 comment · Fixed by #7140
Closed

Missing Windows symbols #7139

virtuald opened this issue Sep 29, 2024 · 1 comment · Fixed by #7140

Comments

@virtuald
Copy link
Member

Building RobotPy alpha yields the following errors on Windows:

 LEDPattern.obj : error LNK2001: unresolved external symbol "public: static class frc::LEDPattern frc::LEDPattern::kOff" (?kOff@LEDPattern@frc@@2V12@A)
SensorUtil.obj : error LNK2001: unresolved external symbol "public: static int const frc::SensorUtil::kAnalogOutputs" (?kAnalogOutputs@SensorUtil@frc@@2HB)
SensorUtil.obj : error LNK2001: unresolved external symbol "public: static int const frc::SensorUtil::kPwmChannels" (?kPwmChannels@SensorUtil@frc@@2HB)
SensorUtil.obj : error LNK2001: unresolved external symbol "public: static int const frc::SensorUtil::kRelayChannels" (?kRelayChannels@SensorUtil@frc@@2HB)
SensorUtil.obj : error LNK2001: unresolved external symbol "public: static int const frc::SensorUtil::kAnalogInputs" (?kAnalogInputs@SensorUtil@frc@@2HB)
SensorUtil.obj : error LNK2001: unresolved external symbol "public: static int const frc::SensorUtil::kDigitalChannels" (?kDigitalChannels@SensorUtil@frc@@2HB)

Per Peter, because #6979 et al, needs to either be declspec(dllimport) or converted to getter functions. Doesn't matter to me either way. dllimport is less breaking for the SensorUtil items? Though, not sure who uses them.

@ThadHouse
Copy link
Member

dllimport doesn't work, because it breaks the static linking scenario. They must be converted to getter functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants