-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RomiGyro class to Romi templates #3810
Comments
It's included in a Romi vendordep, here's the JSON: https://github.com/wpilibsuite/romi-vendordep/blob/main/RomiVendordep.json |
Is this documented? I would be willing to add it to the Romi Getting Started documentation section, but I want to be sure I'm adding accurate information. |
Given that these are included in a vendordep, the example should be updated to reference the vendordep instead of having the |
The current templates (both here and in the VS Code extension don't contain any vendordeps (including the command-based ones). The Romi vendordep is developed in a separate repository, so I'm not sure that it's trivial to pull it in and use it in the examples (maybe the Romi examples should move to the Romi repository because of this?). I recommend waiting for someone on the maintainer team to respond. |
Using that JSON as an online vendor library does not work, the artifacts are not published to Maven. |
Ah, the artifacts are not published to release maven, just development. Thats something that needs to be fixed. |
Was this fixed? |
The Romi vendordep publishing was fixed. |
The RomiReference example project includes a
RomiGyro
class that implements gyro support for the Romi. This class knows internals about the way the Romi communicates with the simulator to provide gyro data that a user could no know.Since this class and the knowledge it has is not documented anywhere in the WPILib documentation, this class should be included in the "Romi - Timed Robot" and "Romi - Command Robot" templates.
An alternative approach would be to add this class to WPILib or to a Romi vendor library. Another alternative approach would be to include the knowledge this class requires in the WPILib documentation so a user could recreate the class from scratch.
The text was updated successfully, but these errors were encountered: