Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes including choosers that don't appear and livewindow widgets that don't appear. #185

Merged
merged 19 commits into from
Oct 11, 2023

Conversation

chauser
Copy link
Contributor

@chauser chauser commented Sep 5, 2023

Several significant changes and two rather cosmetic changes.
Significant changes:

Cosmetic changes:

  1. When SmartDashboard is run with its stdout/stderr visible it produces a lot of uncaught java error index errors and tracebacks for choosers before the set of choices has been loaded.
  2. Similarly, when SmartDashboard does not have a LiveWindow widget for a device type (e.g. CANCoder and many others) it produces an uncaught null pointer error message and traceback.
    Although these errors are uncaught, they occur on single-use callback threads so they don't actually keep SmartDashboard from operating, but they are a major distraction when trying to work on actual problems. Resolves SmartDashboard does not support several LiveWindow types #184; SmartDashboard can't display DifferentialDrive or MecanumDrive in LiveWindow mode. #97 is related in that it mentions the stacktraces for unimplemented device types but it asks to have them implemented.

@chauser chauser changed the title Fix scheduler in live window Improvements to handling of Scheduler type and fix "disappearing Chooser problem" Sep 5, 2023
@sciencewhiz
Copy link
Collaborator

It feels like the disabling DS connection should be a separate PR, since that is a workaround that could hopefully be reenabled in the future.

@sciencewhiz
Copy link
Collaborator

It feels like disabling DS connection may also workaround #81

@chauser
Copy link
Contributor Author

chauser commented Sep 5, 2023

Yes. I've separated the DSClient change into a new branch and will make a new PR for it.

@chauser chauser changed the title Improvements to handling of Scheduler type and fix "disappearing Chooser problem" Improvements to handling of Scheduler type and fix cosmetic uncaught errors Sep 5, 2023
@chauser chauser marked this pull request as draft September 9, 2023 18:11
@chauser chauser changed the title Improvements to handling of Scheduler type and fix cosmetic uncaught errors Bug fixes including choosers that don't appear and livewindow widgets that don't appear. Sep 10, 2023
@chauser
Copy link
Contributor Author

chauser commented Sep 10, 2023

Yes. I've separated the DSClient change into a new branch and will make a new PR for it.

Changes to DSClient are back in this PR but as a delay in starting the DSClient until after the save file is processed, rather than completely disabling it. I think this will be satisfactory in providing both automatic connection and resolving the issue of things not appearing.

@chauser chauser marked this pull request as ready for review September 10, 2023 23:20
@PeterJohnson PeterJohnson merged commit 72dbfdf into wpilibsuite:main Oct 11, 2023
5 checks passed
chauser added a commit to chauser/SmartDashboard that referenced this pull request Sep 3, 2024
… that don't appear (wpilibsuite#185)

Fixed conflicts in moving these changes from the old NT3 world to the NT4-based SmartDashboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants