-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes including choosers that don't appear and livewindow widgets that don't appear. #185
Bug fixes including choosers that don't appear and livewindow widgets that don't appear. #185
Conversation
… cause uncaught errors
…ot each suffer an out-of-bounds array reference
…NT before processing the save file; fixes the problem of string chooser not appearing on dashboard when it is listed in the save file
It feels like the disabling DS connection should be a separate PR, since that is a workaround that could hopefully be reenabled in the future. |
It feels like disabling DS connection may also workaround #81 |
Yes. I've separated the DSClient change into a new branch and will make a new PR for it. |
is misnamed -- it now just ensures that DSClient is not enabled until the save file has been loaded.
Changes to DSClient are back in this PR but as a delay in starting the DSClient until after the save file is processed, rather than completely disabling it. I think this will be satisfactory in providing both automatic connection and resolving the issue of things not appearing. |
… that don't appear (wpilibsuite#185) Fixed conflicts in moving these changes from the old NT3 world to the NT4-based SmartDashboard.
Several significant changes and two rather cosmetic changes.
Significant changes:
SmartDashboard.putData
.NetworkTable.getTable
returns a new table with its own set of entries so it should only be called once per table. Changed Robot.java to implement this behavior.Cosmetic changes:
Although these errors are uncaught, they occur on single-use callback threads so they don't actually keep SmartDashboard from operating, but they are a major distraction when trying to work on actual problems. Resolves SmartDashboard does not support several LiveWindow types #184; SmartDashboard can't display DifferentialDrive or MecanumDrive in LiveWindow mode. #97 is related in that it mentions the stacktraces for unimplemented device types but it asks to have them implemented.