-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Plugin #189
Release Plugin #189
Conversation
2f606b3
to
6333494
Compare
6333494
to
4d368de
Compare
Is there a way to do this without introducing 3 non-namespaced, production dependencies? This makes me really nervous considering how prominent Composer is in the enterprise space 😬 |
@justlevine we've already released this. I wish I'd seen this earlier, but the PR was open for weeks. The updater code is namespaced. Are you referring to something else? |
Sorry GH only pinged me about the approval... must have missed the earlier notifications. My concern is that now in addition to needing to worry about conflicts from a And if there's plans for further adoption of If we really need production Composer dependencies (to handle SemVer or anything else), then we should at least use a library like Strauss or phpscoper to prevent conflicts - doubly so when the deps are generic utilities / intended to be used by multiple coexisting plugins. |
No need to act on this now. My March goal is to commit a dep-free semver + extension version compatibility checker into core, which extensions will be able to tap into uniformly. Once that's in, I'll open an issue/PR.. doubt these deps will release a breaking change before then. |
@justlevine I see. Thanks for explaining. Honestly I'd like to see this plugin folded into WPGraphQL core, or at least managed by that team. It would simplify almost everything related to maintaining this plugin. I look forward to seeing what you put together in March! |
Long term that is indeed the goal (wp-graphql/wp-graphql#1764). Assumingly with the Block Bindings API getting merged in WP 6.5, there shouldn't be any more major blockers 🤞 |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@wpengine/[email protected]
Minor Changes