Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Output faust version in dev|build|start commands. #1874

Merged
merged 12 commits into from
Apr 12, 2024
+80 −44
Merged

Feat: Output faust version in dev|build|start commands. #1874

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d7e4caa
Feat: Output faust version in dev|build|start commands.
theodesp Apr 11, 2024
05cc371
Lint: Fix eslint issue
theodesp Apr 11, 2024
8d97c66
Acceptance Tests: update preview button selectos for WP 6.5
theodesp Apr 12, 2024
83fdb7b
Acceptance Tests: Attempt to fix preview tests
theodesp Apr 12, 2024
c555a8c
Acceptance Test: Use correct variables
theodesp Apr 12, 2024
ed1fa9f
Acceptance Test: Fix cpt_name var
theodesp Apr 12, 2024
ec31be3
Acceptance Test: Remove click event
theodesp Apr 12, 2024
3be607e
Acceptance Test: Attempt to close welcome modals.
theodesp Apr 12, 2024
df2d868
Acceptance Test: Revert last commit
theodesp Apr 12, 2024
439e2e7
Acceptance Test: Update DEVELOPMENT.md
theodesp Apr 12, 2024
dcb4d6d
Acceptance Test: Click Welcome modal if present
theodesp Apr 12, 2024
48cb974
Acceptance Test: Pin e2e tests to WP 6.4
theodesp Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Acceptance Test: Pin e2e tests to WP 6.4
@theodesp
theodesp committed Apr 12, 2024
commit 48cb974da419cb20287c345a8cae743ec861d5f5
2 changes: 1 addition & 1 deletion plugins/faustwp/.docker/Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG WP_VERSION=latest
ARG WP_VERSION=6.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a stopper, but let's add a to-do for later on this... just in case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1875

FROM wordpress:${WP_VERSION}

25 changes: 6 additions & 19 deletions plugins/faustwp/tests/acceptance/CustomPostTypeCest.php
View file
Original file line number Diff line number Diff line change
@@ -2,14 +2,6 @@

class CustomPostTypeCest
{
private function _clickElementIfPresent($I, $element)
{
try {
$I->click($element);
} catch (\PHPUnit_Framework_ExpectationFailedException $e) {
}
return;
}

public function _before(AcceptanceTester $I)
{
@@ -44,18 +36,13 @@ public function i_can_view_the_custom_post_type_preview_link(AcceptanceTester $I

$I->loginAsAdmin();
$I->amEditingPostWithId($cpt_id);
$this->_clickElementIfPresent($I, 'div.components-modal__header > button');
$I->click('button.editor-preview-dropdown__toggle');

$I->click('div.components-guide .components-modal__header button.components-button');
$I->click('button.block-editor-post-preview__button-toggle');
$I->wait(4); // Wait for previewlinks.js to modify button href.
$I->seeLink(
'Preview in new tab',
"${front_end_url}/document/${cpt_name}/?preview=true",
);

$I->click('Preview in new tab');
$I->switchToNextTab();
$I->wait(14); // Wait for authentication
$I->see($cpt_title, 'section h1');
$I->see($cpt_content, 'main.content-single .wrap p');
'Preview in new tab',
"${front_end_url}/document/${cpt_name}/?preview=true&previewPathname=" . rawurlencode("/document/cpt-document-preview/") . "&p=${cpt_id}&typeName=Document",
);
}
}
13 changes: 2 additions & 11 deletions plugins/faustwp/tests/acceptance/PostPreviewCest.php
View file
Original file line number Diff line number Diff line change
@@ -2,14 +2,6 @@

class PostPreviewCest
{
private function _clickElementIfPresent($I, $element)
{
try {
$I->click($element);
} catch (\PHPUnit_Framework_ExpectationFailedException $e) {
}
return;
}
/**
* Ensure the nodejs site url is set as the post preview url.
*/
@@ -31,12 +23,11 @@ public function i_can_view_the_post_preview_link(AcceptanceTester $I)

$I->loginAsAdmin();
$I->amEditingPostWithId($post_id);
$this->_clickElementIfPresent($I, 'div.components-modal__header > button');
$I->click('button.editor-preview-dropdown__toggle');
$I->click('button.block-editor-post-preview__button-toggle');
$I->wait(4); // Wait for previewlinks.js to modify button href.
$I->seeLink(
'Preview in new tab',
"${front_end_url}/${post_name}/?preview=true",
"${front_end_url}/${post_name}/?preview=true&previewPathname=" . rawurlencode("/post-preview-post/") . "&p=${post_id}&typeName=Post",
);

$I->click('Preview in new tab');