-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client utils to app router package #1659
Conversation
🦋 Changeset detectedLatest commit: a13412e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
… requiring strict module resolution (file extensions, etc)
"module": "ESNext", | ||
"moduleResolution": "Bundler", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to use package exports in TypeScript, you must set moduleResolution
to Node16
, NodeNext
, or Bundler
. Since we don't want to enforce strict module resolution with file extensions, etc. on our users, we use Bundler
since the other two require that strict behavior.
LGTM. It looks like there is a dependency check failure. |
Fixed! |
Tasks
Description
This PR introduces a mechanism to make GraphQL requests on the client side within a Faust app router project. In order to do so, the
<FaustProvider>
component was brought back and can be imported via:This PR also sets us up to use package exports so we can better isolate our RSC and SSR implementations.
Related Issue(s):
Testing
npm install
)npm run build -w @faustwp/experimental-app-router
)npm run dev -w @faustwp/app-router-example
)http://localhost:3000/making-client-queries
and notice the client query works properly.Screenshots
Bundle size is not effected outside of client data fetching.
Bundle before this PR:
Bundle after:
Documentation Changes
Dependant PRs