Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app router build publish #1651

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

blakewilson
Copy link
Contributor

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Since we removed the experimental app router package from the "build" step to not conflict with our workflows re:node/next required versions, the build was excluded from the release packages action, and thus published a broken build. This fixes the workflow and adds a changeset to make a corrective follow up release.

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@blakewilson blakewilson requested a review from a team as a code owner November 14, 2023 15:36
Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 595b9a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/experimental-app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@blakewilson blakewilson merged commit 6276c80 into canary Nov 14, 2023
18 checks passed
@blakewilson blakewilson deleted the fix-app-router-build-publish branch November 14, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants