-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MERL-1185: Redirect Off Doesn't Rewrite Post Preview Link #1641
Conversation
Sync Canary & Main
Sync `canary` to `main`
Sync `canary` -> `main`
Sync `canary` -> `main`
Sync canary -> main
Sync `canary` -> `main`
Sync `canary` -> `main`
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
@matthewguywright Looks like there is some plugin tests failing |
819e8aa
to
d09e36b
Compare
Sync `canary` -> `main`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Would this be considered a breaking change though?
Accidentally clicked "requested changes"
@matthewguywright some conflicts there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matt, nice work with this. I checked to ensure the redirect is still working when both unchecked and checked. All seems to be operating smoothly. LGTM!
Description
Updated post preview link to only rewrite if enable redirects is off.
Testing
Enable public route redirects
is unchecked