Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERL-1185: Redirect Off Doesn't Rewrite Post Preview Link #1641

Merged
merged 24 commits into from
Nov 17, 2023

Conversation

matthewguywright
Copy link
Contributor

Description

Updated post preview link to only rewrite if enable redirects is off.

Testing

  1. Setup a WP instance with Faust
  2. Ensure the FaustWP Plugin is linked or installed correctly
  3. In Faust Plugin, make sure Enable public route redirects is unchecked
  4. Clicking preview in a post should work properly using Wordpress default post preview link

@matthewguywright matthewguywright requested a review from a team as a code owner November 9, 2023 16:42
Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: 91442f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 9, 2023

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@blakewilson
Copy link
Contributor

@matthewguywright Looks like there is some plugin tests failing

Copy link
Contributor

@blakewilson blakewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would this be considered a breaking change though?

@blakewilson blakewilson dismissed their stale review November 14, 2023 14:41

Accidentally clicked "requested changes"

@theodesp
Copy link
Member

@matthewguywright some conflicts there

@josephfusco josephfusco added the package: faustwp Related to the companion WordPress plugin label Nov 16, 2023
Copy link
Contributor

@TeresaGobble TeresaGobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matt, nice work with this. I checked to ensure the redirect is still working when both unchecked and checked. All seems to be operating smoothly. LGTM!

@matthewguywright matthewguywright merged commit 42cbe14 into canary Nov 17, 2023
18 checks passed
@matthewguywright matthewguywright deleted the fix/mw-merl-1185 branch November 17, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: faustwp Related to the companion WordPress plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants