Support for multiple queries in a Faust template #1626
Conversation
|
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
245.53 KB (🟡 +202 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/ |
289 B |
245.81 KB | 70.23% (+/- <0.01%) |
/[...wordpressNode] |
301 B |
245.82 KB | 70.23% (+/- <0.01%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.
| const queryCalls = template.queries.map((query) => { | ||
| return client.query({ | ||
| query, | ||
| variables: templateVariables, |
There was a problem hiding this comment.
This is the tricky part. Each query may need different variables and not we are bundling all the potential variables on each requests. This could get out of hand soon.
| variables: templateVariables, | ||
| }); | ||
| }); | ||
| const queriesRes = await Promise.all(queryCalls); |
There was a problem hiding this comment.
Promise.all will fire up all promises at once. However this would probably fail if one request is dependent on another for specific variables. Also if one of them fails then all of them will fail.
Not sure how reasonable is this to do....
Tasks
Description
Provide a way to use multiple queries in a Faust template.
Introduces the new
Component.queriesproperty to execute multiple queries, and theuseFaustQueryhook to retrieve the data.Related Issue(s):
Testing
npm installnpm run buildnpm run dev -w @faustwp/getting-started-examplewp-templates/single.jsScreenshots
Documentation Changes
Dependant PRs