Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "true" in meal participant calculation #229

Merged
merged 4 commits into from
May 2, 2024
Merged

fix "true" in meal participant calculation #229

merged 4 commits into from
May 2, 2024

Conversation

wp99cp
Copy link
Owner

@wp99cp wp99cp commented May 2, 2024

The funciton calcRecipeParticipants expects a number as the 5th argument, however a bool was given back from the frontend (the override checkbox value, instead of the actual value inside the override participants field)

Thanks @maede97, #228 (comment)

Copy link

github-actions bot commented May 2, 2024

Todos before releasing a new version

  • Check release notes: All new features/changes included? Date correct?
  • Check help-page messages: Are they all up to date? Update screenshots. Is the date correct?
  • Check preview build and test it with the productive database.
  • Deploy new revision of the PDF-Export Service

Copy link

github-actions bot commented May 2, 2024

Visit the preview URL for this PR (updated for commit 7d237f4):

https://cevizh11--pr229-develop-eo32wsaq.web.app

(expires Thu, 09 May 2024 20:16:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 24bd171033fed39f354a6ae9ae7cd77031a13d97

Copy link

github-actions bot commented May 2, 2024

Visit the preview URL for this PR (updated for commit 7d237f4):

https://cevizh11-menuplanung--pr229-develop-ztzn91sl.web.app

(expires Thu, 09 May 2024 20:16:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 80e5384ad8a7f421f0e01a4bd0baf416d27d64c2

Copy link

github-actions bot commented May 2, 2024

  • Version changed since last release! Version of this release: 1.15.3 (patch).

Copy link

github-actions bot commented May 2, 2024

Todos before releasing a new version

  • Check release notes: All new features/changes included? Date correct?
  • Check help-page messages: Are they all up to date? Update screenshots. Is the date correct?
  • Check preview build and test it with the productive database.
  • Deploy new revision of the PDF-Export Service

@wp99cp wp99cp merged commit 8c17e7f into master May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants