Use select2 dropdownParent attr for css targetting #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When interacting with a select2 field, this attaches the dropdown container as a child of the attribute field view, using the `dropdownParent` option in select2. This allows us to target the specific fields that we need to style with css using parent selectors, without resorting to hacks like trying to set a classname on the container element when it's created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interacting with a select2 field, this attaches the dropdown container as a child of the attribute field view, using the
dropdownParentoption in select2.This allows us to target the specific fields that we need to style with css using parent selectors, without resorting to hacks like trying to set a classname on the container element when it's created.
Replaces #749, as a fix for #748.