Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lazyload package to v3.0.17 #7235

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

wordpressfan
Copy link
Contributor

Description

Fixes #7115
Fixes #7202

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

You can check the changelog here: https://github.com/wp-media/rocket-lazyload-common/releases/tag/v3.0.17

Technical description

Documentation

We update this package in one PR here.

New dependencies

N/A

Risks

N/A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

N/A

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 93fef5c1 7.14% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (93fef5c) Report Missing Report Missing Report Missing
Head commit (7342b61) 39336 17143 43.58%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7235) 14 1 7.14%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@wordpressfan
Copy link
Contributor Author

Thanks @audrasjb for ur contribution here.

@wordpressfan wordpressfan added this to the 3.18.1 milestone Jan 21, 2025
@audrasjb
Copy link

Thanks everyone for fixing this!
Can't wait for seeing this changeset in the plugin, now :)

It will fix an accessibility compliance issue on a bucking bunch of websites!! (basically on each non-english website using this feature of WP Rocket) 👍

@Mai-Saad
Copy link
Contributor

@Miraeld
Copy link
Contributor

Miraeld commented Jan 24, 2025

Everything's green.
testrail-report-684.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants