-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6960 Beacon script can be injected multiple times when there are multiple </body> in the page. #7231
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
tests/Fixtures/inc/Engine/Common/PerformanceHints/Frontend/Subscriber/HTML/double_body_tag.html
Outdated
Show resolved
Hide resolved
Everything green ! Great! |
Description
Fix multiple tag beacon script issue.
Fixes #6960
Type of change
Detailed scenario
Create a template with multiple
</body>
tag and open in a browser, check the script and notice that the beacon script is run twice(inserted twice)Technical description
Documentation
Change the beacon script insertion with
str_replace
topreg_replace
Mandatory Checklist
Code validation
Code style