Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multisite Cache Deletion Issue with lazyload background images feature #7226

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

wordpressfan
Copy link
Contributor

@wordpressfan wordpressfan commented Jan 14, 2025

Description

Fixes #6340

Here we unify the caching directory path for lazyload background images feature.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Everything is mentioned in the issue itself, u can install multisite and add some background images in some pages (different sub-sites) then in one site try clearing the cache, this will remove the background images for all sub-sites.

Technical description

Here we unify the way that we instantiate "lazyload_css_cache" in the container service provider.

Documentation

N/A

New dependencies

N/A

Risks

I think we will need to clear cache with update to that version because the files urls are changed, but need to confirm that with QA and product.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

N/A

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@wordpressfan wordpressfan self-assigned this Jan 14, 2025
@wordpressfan wordpressfan marked this pull request as ready for review January 14, 2025 10:12
@wordpressfan wordpressfan requested a review from a team January 14, 2025 10:13
Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e726c3d1 54.55% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e726c3d) Report Missing Report Missing Report Missing
Head commit (fefa3b0) 38768 17148 44.23%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7226) 11 6 54.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Site Cache Deletion Issue with WP Rocket's Background CSS Image Caching
3 participants