-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to update lists from JSON files and clear cache #7054
Conversation
* **DynamicLists.php** - Add `update_lists_from_files` method to clear transient cache and update lists from JSON files - Call `remove_lists_cache` and `get_lists` methods from each provider's data manager in `update_lists_from_files` * **AbstractDataManager.php** - Add `remove_lists_cache` method to delete transient cache * **Subscriber.php** - Modify `wp_rocket_upgrade` callback to call `update_lists_from_files` method - Add `update_lists_from_files` method to call `$this->dynamic_lists->update_lists_from_files()`
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Miraeld, @wordpressfan, thank you.
All looks good on test env with this PR.
Related Test Plan Report here:
testrail-report-658.pdf
DynamicLists.php
update_lists_from_files
method to clear transient cache and update lists from JSON filesremove_lists_cache
andget_lists
methods from each provider's data manager inupdate_lists_from_files
AbstractDataManager.php
remove_lists_cache
method to delete transient cacheSubscriber.php
wp_rocket_upgrade
callback to callupdate_lists_from_files
methodupdate_lists_from_files
method to call$this->dynamic_lists->update_lists_from_files()
Description
Fixes #6920
This update modifies the dynamic lists handling, improving the performance and reliability of the feature as the customer won't have to wait a week before getting the new exclusions updated.
Type of change
Detailed scenario
Update WP Rocket
Technical description
Documentation
We simply delete the transient cache before fetching the dynamic list from the file within the ZIP archive.
New dependencies
Risks
Mandatory Checklist
Code validation
Code style