-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6764: Refactor lcp beacon script #6789
Conversation
Change the structure of the beacon script to include a new class `RocketBeacon` which will contains more generic functions that could be shared with other features.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Should this PR be done against |
@jeawhanlee I've updated action names and everything related to that. @Tabrisrp I've changed the based branch. |
Change the structure of the beacon script to include a new class
RocketBeacon
which will contains more generic functions that could be shared with other features.Description
Fixes #6764
Documentation
User documentation
This shouldn't impact users.
Technical documentation
The beacon script has been renamed to
wpr-beacon.js
& has been refactored.This refactor includes the addition of a new class named
RocketBeacon
which contains generic functions used later on byRocketLcpBeacon
class.It will allow us to add more feature easily to avoid duplication.
In order to test this PR, wp-media/wp-rocket-e2e#124 needs to be merged into e2e.
Type of change
Checklists
Feature validation
Documentation
Code style
Observability
Risks