Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6756 Increase phpstan level 2 #6761

Merged
merged 64 commits into from
Jul 18, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jul 5, 2024

Description

Fixes #6756

Documentation

User documentation

Technical documentation

Some tests were marked as skipped because they do not perform assertions in their current form. They need to be revisited.

Notable changes:

  • Return default values if the user data could not be fetched (settings dashboard)
  • Make sure the label property is correctly set before using it when adding LCP data from AJAX request
  • Bail-out early if the src property of the DB entry is empty when adding the fetchpriority attribute to an image

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Miraeld Miraeld self-assigned this Jul 5, 2024
Copy link

codacy-production bot commented Jul 5, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d70151f1 68.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d70151f) Report Missing Report Missing Report Missing
Head commit (0a26436) 37382 14543 38.90%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6761) 25 17 68.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Tabrisrp Tabrisrp added dev initiative type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Jul 12, 2024
@Tabrisrp Tabrisrp changed the title DRAFT: Closes #6756: increase phpstan level 2 Closes #6756: increase phpstan level 2 Jul 12, 2024
@Tabrisrp Tabrisrp changed the title Closes #6756: increase phpstan level 2 Closes #6756 Increase phpstan level 2 Jul 12, 2024
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran smoke & lcp tests on e2e for this branch, all passed.
Executed TP with following report:
testrail-report-619.pdf
One TC is failed but looks like failing on trunk too. Will be addressed separately.

@Tabrisrp Tabrisrp added this pull request to the merge queue Jul 18, 2024
Merged via the queue into develop with commit 7cab3aa Jul 18, 2024
13 checks passed
@Tabrisrp Tabrisrp deleted the enhancement/6756-increase-phpstan-level-2 branch July 18, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev initiative type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase PHPStan level to 2
4 participants