Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude 'addsauce.com' to prevent breaking Sauce embeds #6292

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mrjamesriley
Copy link

@mrjamesriley mrjamesriley commented Nov 27, 2023

Description

Adds 'addsauce.com' to the dynamic-list of domains to exclude from being impacted by wp-rocket. We were previously 'snapppt.com' (which is already included in the list and we would like that to remain as many existing uses of our embed till use this older domain for their embed).

We have a few customers using WP-rocket, for which our embed is breaking.
This will resolves matters for them.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

Please describe in this section if there is any change to the groomed solution, and why.

Checklists

Generic development checklist

For the following which is not applicable, I've marked it as checked:

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant