Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPCS errors #87

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix PHPCS errors #87

merged 2 commits into from
Aug 6, 2024

Conversation

swissspidy
Copy link
Member

No description provided.

@swissspidy swissspidy added this to the 2.0.13 milestone Aug 5, 2024
@swissspidy swissspidy requested a review from a team as a code owner August 5, 2024 14:19
@ernilambar
Copy link
Member

Tests are failing in SQLite database. wp site empty --yes does not seem to work as expected in SQLite.

@ernilambar
Copy link
Member

After some digging, I found @require-mysql in the Behat tests for wp site empty. So may be we should keep it here also.

@swissspidy
Copy link
Member Author

@ernilambar It‘s not something introduced by this PR, but wanna push a fix to this branch? Otherwise let‘s handle it separately.

@swissspidy swissspidy merged commit cd17715 into main Aug 6, 2024
34 checks passed
@swissspidy swissspidy deleted the fix/phpcs branch August 6, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernilambar ernilambar ernilambar approved these changes

Assignees
No one assigned
Labels
bug scope:testing
Projects
None yet
Milestone
2.0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@swissspidy @ernilambar