Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: gettext/gettext 5.x #217

Closed
wants to merge 598 commits into from
Closed

WIP: gettext/gettext 5.x #217

wants to merge 598 commits into from

Conversation

drzraf
Copy link

@drzraf drzraf commented Jun 18, 2020

Roadblock of https://github.com/php-gettext/Twig-Scanner
(back from #59 and #211)

Note:

  • Gettext 5 is PHP 7.2

Questions:

  • Which version of PHP 7.x will be required in v3 in December? 7.1, 7.2, ... ?
  • Can a gettext-5 already exists somewhere in this repository? Or within a wp-cli-v3 branch?

swissspidy and others added 30 commits April 24, 2019 17:36
@swissspidy
Implement CS checking based on the WP_CLI_CS ruleset (wp-cli#156)
e4edd2f 
Implement CS checking based on the `WP_CLI_CS` ruleset
@schlessera
Fine-tune property and variable name whitelisting
8826e87
@schlessera
Correct whitelist comment
f63b1e7
@schlessera
Merge pull request wp-cli#161 from wp-cli/phpcs-scope-variable-whitel…
e7a3650 
…ist-more-finely

Fine-tune property and variable name whitelisting
@schlessera
Update README.md file
5d39a8d
@schlessera
Merge pull request wp-cli#162 from wp-cli/update-readme-220
e52a9a6 
Update README.md file
@michaelzangl
Add test that .js and .jsx files are parsed for javascript.
ba1cdfd
@michaelzangl
Workaround for parsing dynamic import.
6be1c37
@michaelzangl
Fix wp-cli#98: Remove workaround since peast was fixed.
a26eaf8
@michaelzangl
Fix coding style.
4c5e301
@swissspidy
make pot command: Allow .jsx files. (wp-cli#160)
af81433 
make pot command: Allow .jsx files.
@ocean90
Add test to cover translator comments with tab indentations
d7475e9
@ocean90
Update test framework to ^2.1.3.
d1a27ad 
See wp-cli/wp-cli-tests#69
@ocean90
Insert tab with a placeholder to make it independent of editor configs
e108422
@ocean90
Test: Require specific commit for gettext parser fix
dc80af1
@ocean90 @schlessera
Fix typo
b0adb7d 
Co-Authored-By: Alain Schlesser <[email protected]>
@ocean90
Require v4.6.3 of gettext/gettext
83016a0
@swissspidy
Merge pull request wp-cli#170 from ocean90/add/test-comments-with-tab…
09c32cd 
…-indentation

Add test to cover translator comments with tab indentations
@l3ku
Sort translation files by name to ensure same order on all systems
11fdcef 
Closes: wp-cli#171.
@swissspidy
Try adding some more tests for include/exclude
36edba9
@swissspidy
Trim leading slashes
763941a
@swissspidy
Fix gitignore file to not exclude nested vendor dirs
feeb9d8
@swissspidy
Add new test file
3172ea7
@schlessera
Merge pull request wp-cli#173 from l3ku/master
4ab93fd 
Sort translation files by name to ensure same order on all systems
@schlessera
Merge branch 'master' into dynamic-import-workaround
f040590
@schlessera
Merge pull request wp-cli#164 from michaelzangl/dynamic-import-workar…
6c1535e 
…ound

Workaround for parsing dynamic import.
@schlessera
Merge pull request wp-cli#149 from connerbw/patch-1
502185d 
Avoid throwing a notice about `strpos(): Empty needle` when going through include paths
@schlessera
Merge branch 'master' into try/172-exclude-include
3033417
@schlessera
Merge branch 'master' into try/172-exclude-include
c35bd16
@schlessera
Merge branch 'try/172-exclude-include' of https://github.com/wp-cli/i…
676f99a 
…18n-command into try/172-exclude-include
schlessera and others added 17 commits October 12, 2021 16:05
@schlessera
Update file(s) from wp-cli/.github
ea8a6b3
@swissspidy
Merge pull request wp-cli#284 from cpiber/master
9cff1ef
@schlessera
Regenerate README file - 2021-10-14
fba0bbb
@swissspidy
Merge pull request wp-cli#289 from wp-cli/regenerate-readme
0f6184d
@schlessera
Update file(s) from wp-cli/.github
aca5f3b
@oandregal
Adds new field to translate
1b5ddd4
@schlessera
Merge pull request wp-cli#292 from oandregal/add/new-field-to-translate
e74ecbc
@schlessera
Update file(s) from wp-cli/.github
83a3e20
@schlessera
Update file(s) from wp-cli/.github
bb0d1ee
@wojsmol
Add php 8.1 support
f0fbd30
@schlessera
Merge pull request wp-cli#293 from wojsmol/fix/php8.1-compat
e9eef8a
@schlessera
Update file(s) from wp-cli/.github
1760605
@swissspidy
Fix JS string extraction with unsupported argument type
7fa77a3
@schlessera
Update file(s) from wp-cli/.github
ffdf0ba
@schlessera
Merge pull request wp-cli#296 from wp-cli/fix/294-incorrect-string
ecfe2c2
@dependabot-preview @schlessera
Update gettext/gettext requirement from ^4.8 to ^5.4
e6e2000 
Updates the requirements on [gettext/gettext](https://github.com/oscarotero/Gettext) to permit the latest version.
- [Release notes](https://github.com/oscarotero/Gettext/releases)
- [Changelog](https://github.com/php-gettext/Gettext/blob/master/CHANGELOG.md)
- [Commits](php-gettext/Gettext@v4.8.0...v5.4.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@schlessera
WIP: php-gettext 5
0f124f2
@schlessera schlessera closed this Jan 6, 2022
@schlessera
Copy link
Member

@drzraf This PR was moved to the gettext-5 branch within the WP-CLI repo. This way, you should be able to pull it in via Composer. Feel free to create PRs against that gettext-5 branch as needed, I'll merge them in quick turn-arounds, as this is not directly impacting WP-CLI compatibility.

@swissspidy swissspidy mentioned this pull request Feb 18, 2022
Closed
1 task
@drzraf drzraf mentioned this pull request Mar 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.