Tests that show register shutdown function issue (#70) is invalid #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould fail. So, the issue is invalid.
2 tasks
johnbillion
approved these changes
Sep 18, 2024
features/cron-event.feature
Outdated
|
|
||
| register_shutdown_function(function() { | ||
| error_log('LOG A SHUTDOWN FROM ERROR'); | ||
| // file_put_contents( dirname( __FILE__ ) . '/log.log', print_r( 'Shutdown called correctly', true ) . "\r\n\r\n", FILE_APPEND ); |
There was a problem hiding this comment.
This line can be removed.
swissspidy
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #70. This one is sort of complicated to reproduce accurately, but these tests demonstrate that a registered shutdown function is capable of writing to a file, so the reported issue is invalid, and can probably be safely closed as a "will not fix". Brian and I decided that we preferred the
error_log()demonstration overfile_put_contents()for Behat, but we tested both ways and the result was the same.Submitted during Contributor Day.