GH Actions/tests: prevent warning about outdated configuration being used #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used
The configuration file specification has undergone changes in PHPUnit 9.3 and 10.0.
Most notably:
* In PHPUnit 9.3, the manner of specifying the code coverage configuration has changed.
* In PHPUnit 10.0, a significant number of attributes of the `<phpunit>` element were removed or renamed.
When running PHPUnit 10 with a PHPUnit 9 style configuration file, PHPUnit 10 can show a warning:
```
There was 1 PHPUnit test runner deprecation:
1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!
```
The `--migrate-configuration` command can upgrade a configuration for the changes in the format made in PHPUnit 9.3 and 10.0/10.1, but some of the changes in the configuration format in PHPUnit 10 don't have one-on-one replacements and/or are not taken into account.
This commit is a way to "future proof" the test workflow a little by preventing that PHPUnit warning from potentially failing a build in the future.
Notes:
* If/when PHPUnit 11 starts to be supported, the bash condition will need updating to also recognize PHPUnit 11.
* The `--migrate-configuration` script will fail (exit code `1`) if no update is needed, like if one of the repos would have a PHPUnit 10-style config file.
To prevent this from failing the test job, I'm explicitly setting `continue-on-error: true`.
swissspidy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration file specification has undergone changes in PHPUnit 9.3 and 10.0.
Most notably:
<phpunit>element were removed or renamed.When running PHPUnit 10 with a PHPUnit 9 style configuration file, PHPUnit 10 can show a warning:
The
--migrate-configurationcommand can upgrade a configuration for the changes in the format made in PHPUnit 9.3 and 10.0/10.1, but some of the changes in the configuration format in PHPUnit 10 don't have one-on-one replacements and/or are not taken into account.This commit is a way to "future proof" the test workflow a little by preventing that PHPUnit warning from potentially failing a build in the future.
Notes:
--migrate-configurationscript will fail (exit code1) if no update is needed, like if one of the repos would have a PHPUnit 10-style config file.To prevent this from failing the test job, I'm explicitly setting
continue-on-error: true.