GH Actions/testing: minor simplification/maintainability improvement #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup-PHP has an alias available for "PHP next" named `nightly`.
While this change doesn't remove the annual task of updating the matrix when a new PHP version gets released, it does make this update a little less error prone as updating the `continue-on-error` conditions lower down in the scripts (disconnected from the matrix set up) can easily be forgotten.
There are a few caveats to keep in mind about this change though:
* Manually updating the matrix and the workflow gives (of course) more control over the exact PHP versions being used.
* When using `nightly`, that control is relinquished partially to setup-php and partially to PHP itself as `nightly` will generally always be "PHP next".
This means that `nightly` will effectively become PHP `8.5` at the time when setup-php updates the alias, which can be at any point in time between PHP src branching off the PHP `8.4` branch (happened last week when the first RC was created) and the moment PHP `8.4` is released.
Note: there is [some discussion going](shivammathur/setup-php#867) to clarify when "nightly" becomes "PHP next next" (`8.5`). Looks like the current intention is to not change it until PHP 8.4 has been released.
You can always check exactly what version is used for `nightly` though, by folding out the "Set up PHP environment" step and checking the PHP version listed there.
Ref:
* https://github.com/shivammathur/setup-php/?tab=readme-ov-file#php-version-optional
swissspidy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup-PHP has an alias available for "PHP next" named
nightly.While this change doesn't remove the annual task of updating the matrix when a new PHP version gets released, it does make this update a little less error prone as updating the
continue-on-errorconditions lower down in the scripts (disconnected from the matrix set up) can easily be forgotten.There are a few caveats to keep in mind about this change though:
nightly, that control is relinquished partially to setup-php and partially to PHP itself asnightlywill generally always be "PHP next".This means that
nightlywill effectively become PHP8.5at the time when setup-php updates the alias, which can be at any point in time between PHP src branching off the PHP8.4branch (happened last week when the first RC was created) and the moment PHP8.4is released.Note: there is some discussion going to clarify when "nightly" becomes "PHP next next" (
8.5). Looks like the current intention is to not change it until PHP 8.4 has been released.You can always check exactly what version is used for
nightlythough, by folding out the "Set up PHP environment" step and checking the PHP version listed there.(example from a repo using
nightlyon a run from today)Ref: