GH Actions/linting: show deprecations when linting #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While rare, there are some deprecations which PHP can show when a file is being linted. By default these are ignored by PHP-Parallel-Lint. However, there is an option to show them, so let's turn that option on. To make the option effective, we also need to ensure that PHP is run in a way that all errors will be shown, which is not the case by default, so this also sets some `ini-values` for PHP to a more optimal setting for CI. Lastly, in the command, let's also make the package directory iteration a little faster by preventing parallel lint from having to iterate through the `.git` directory when there are no PHP files to be found there anyway.
swissspidy
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rare, there are some deprecations which PHP can show when a file is being linted. By default these are ignored by PHP-Parallel-Lint.
However, there is an option to show them, so let's turn that option on.
To make the option effective, we also need to ensure that PHP is run in a way that all errors will be shown, which is not the case by default, so this also sets some
ini-valuesfor PHP to a more optimal setting for CI.Lastly, in the command, let's also make the package directory iteration a little faster by preventing parallel lint from having to iterate through the
.gitdirectory when there are no PHP files to be found there anyway.