Add unequip all gems button to gem summary #4266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337LutZ
requested changes
Nov 19, 2024
| display: flex; | ||
| align-items: center; | ||
| padding: 0; | ||
| color: #ef9eaa; |
There was a problem hiding this comment.
Please use a color var for this, or maybe try to copy the btn-reset styling?
|
|
||
| const headerElement = this.container.headerElement; | ||
| if (headerElement) { | ||
| const unequipButton = document.createElement('button'); |
There was a problem hiding this comment.
Would be nice to just make rename this file to tsx and use fragments like in Cata
There was a problem hiding this comment.
I was hesitated to do so because making one component into tsx is inconsitent to the other files if no plan to make all of them tsx. But that is my opinion.
There was a problem hiding this comment.
You have to start somewhere :D That's how I did it for the Cata repo as well. If you never do it you'll also never change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the same unequip gems feature from Cata to Wotlk because why not