Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating default Retribution APL #4184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Surveillant0
Copy link
Contributor

DS > CS rotation (aka High-roll) as the new default
includes a condition to prio CS higher if Libram duration is low
for people without the Libram, the rotation will end up doing CS > DS instead, unless that action is disabled
however CS > DS is still a perfectly fine and optimal rotation anyway
also includes cancelaura action for Shadowmourne but this is disabled by default, as it is currently bugged in-game

DS > CS rotation (aka High-roll)
@Surveillant0
Copy link
Contributor Author

not sure if I need to fix a bug somewhere or if I need to update expected results, first time updating an APL

@kayla-glick
Copy link
Contributor

Hey @Surveillant0! Looks like the update is making the tests fail (which isn't surprising). Since the numbers went up I assume that's totally fine, so you can run make update-tests then commit those changes and it should be good!

@Surveillant0
Copy link
Contributor Author

Hey @Surveillant0! Looks like the update is making the tests fail (which isn't surprising). Since the numbers went up I assume that's totally fine, so you can run make update-tests then commit those changes and it should be good!

thanks I will do this as soon as I am able to! appreciate the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants