Skip to content

Don't arbitrarily constrain dependency versions#424

Merged
nicknisi merged 1 commit intoworkos:mainfrom
mrcljx:patch-1
Mar 28, 2025
Merged

Don't arbitrarily constrain dependency versions#424
nicknisi merged 1 commit intoworkos:mainfrom
mrcljx:patch-1

Conversation

@mrcljx
Copy link
Contributor

@mrcljx mrcljx commented Mar 28, 2025

Description

For libraries, the best practice is to only list known incompatibilities and not potential future incompatibilities. Using <= (or ~=) constraints can:

  • Lead to dependency resolution conflicts for downstream consumers
  • Prevent users from using newer versions of dependencies that are likely still compatible
  • Reduce composability in larger environments or monorepos

Note how pydantic itself has no <= constraints. You'll find the same with other libraries.

@mrcljx mrcljx requested a review from a team as a code owner March 28, 2025 11:37
@mrcljx mrcljx requested a review from nicknisi March 28, 2025 11:37
Copy link
Member

@nicknisi nicknisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mrcljx!

@nicknisi nicknisi merged commit dac0c89 into workos:main Mar 28, 2025
6 checks passed
@mrcljx mrcljx deleted the patch-1 branch March 29, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants