Conversation
Go, Kotlin, and PHP need their existing API surface to preserve public aliases and positional argument slots. Extract it before overwriting the SDK instead of only reporting compatibility changes after generation. Keep the EXIT trap active so temporary baseline files and Node worktrees are cleaned up on both success and failure.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDK generation currently compares compatibility after generating, but only Node receives the existing API surface as a generation input. The Go/Kotlin/PHP emitters need that baseline to retain public aliases and avoid moving existing positional arguments when the spec adds fields.
--api-surfaceoption.Companion to workos/oagen-emitters#260. No spec/API change, new CI pipeline, or SDK compilation harness is introduced.
Validation
npxboundary to inspect arguments; they do not compile or execute generated SDKs.npm test: 153 passed, zero skipped.bash -n scripts/sdk-generate.shpassed.npm run build:policypassed with the existing TypeScript 7 experimental-API warning.Rollout
Keep this draft until the emitter companion is released and this repository installs that version. This PR deliberately does not pin an unpublished Git dependency or publish a package. The full consumer SDK build/test matrix still needs to run with that candidate; source generation and script-unit results are not a replacement for it.