Skip to content

Fix naming inconsistency between Vector type and TensorSchema #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sroussey merged 2 commits into from
Jan 4, 2026
Merged

Fix naming inconsistency between Vector type and TensorSchema #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf026e
Initial plan
Copilot Jan 4, 2026
afe5fa0
Fix naming inconsistency: rename Vector to Tensor in Tensor.ts
Copilot Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/util/src/vector/Tensor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ export const TensorType = {
export type TensorType = (typeof TensorType)[keyof typeof TensorType];

/**
* Vector schema for representing vectors as arrays of numbers
* Tensor schema for representing tensors as arrays of numbers
* @param annotations - Additional annotations for the schema
* @returns The vector schema
* @returns The tensor schema
*/
export const TensorSchema = (annotations: Record<string, unknown> = {}) =>
({
Expand All @@ -33,24 +33,24 @@ export const TensorSchema = (annotations: Record<string, unknown> = {}) =>
type: "string",
enum: Object.values(TensorType),
title: "Type",
description: "The type of the vector",
description: "The type of the tensor",
},
data: TypedArraySchema({
title: "Data",
description: "The data of the vector",
description: "The data of the tensor",
}),
shape: {
type: "array",
items: { type: "number" },
title: "Shape",
description: "The shape of the vector (dimensions)",
description: "The shape of the tensor (dimensions)",
minItems: 1,
default: [1],
},
normalized: {
type: "boolean",
title: "Normalized",
description: "Whether the vector data is normalized",
description: "Whether the tensor data is normalized",
default: false,
},
},
Expand All @@ -59,4 +59,4 @@ export const TensorSchema = (annotations: Record<string, unknown> = {}) =>
...annotations,
}) as const satisfies JsonSchema;

export type Vector = FromSchema<ReturnType<typeof TensorSchema>, TypedArraySchemaOptions>;
export type Tensor = FromSchema<ReturnType<typeof TensorSchema>, TypedArraySchemaOptions>;