Add Float16Array type preservation to normalize function #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
normalizefunction inVectorUtils.tswas missing an instanceof check forFloat16Array, causing it to fall through to the defaultFloat32Arrayreturn, losing type information.Changes:
typeof Float16Array !== "undefined")new Float16Array(normalized)when input is Float16ArrayImplementation:
The runtime check ensures compatibility with environments where Float16Array is unavailable (Node.js < v22) while preserving type information where it exists.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.