Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arab latin-script file #16

Merged
merged 9 commits into from
Oct 13, 2018
Merged

New arab latin-script file #16

merged 9 commits into from
Oct 13, 2018

Conversation

AhmedRedaAmin
Copy link
Contributor

The most recent version of the list compiled for get-alex/alex#220

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! On tiny request, and: could you also call this file ar.json (drop the index-)?

index-ar.json Outdated
"zobrak": 2,
"zobry": 2,
"zwamel": 2
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, could you add a newline at the end of the file?

@AhmedRedaAmin
Copy link
Contributor Author

Okay @wooorm done !

@wooorm
Copy link
Member

wooorm commented Oct 12, 2018

OK, two more things.
Could you add the inspiration for this file (where you got the phrases from), and an entry in the language support section?

@AhmedRedaAmin
Copy link
Contributor Author

@wooorm , I already have the sources on my repo , how do you want me to transfer them ?

@wooorm
Copy link
Member

wooorm commented Oct 12, 2018

@AhmedRedaAmin You need to add them to this branch. If you push them to the master branch on your fork (GitHub says) they’re added here automatically!

@AhmedRedaAmin
Copy link
Contributor Author

AhmedRedaAmin commented Oct 12, 2018

Lol @wooorm , I know how to make a pull request Titus , I was more asking about the format that you expect from me , a list in a separate file , embedding them as a comment in the .json , perhaps adding them to the readme ? You know , to keep the project structure nice and uniform .

EDIT: seems there is no such thing as .json comment , my apologies :'D , also I just saw the French team , they added it directly to the readme . ON IT !

@AhmedRedaAmin
Copy link
Contributor Author

AhmedRedaAmin commented Oct 12, 2018

Okay , this was more difficult than anticipated , @wooorm any hint on the rules at work here ?

EDIT : found the rules , says here the indent is 2 spaces , I did the 2 spaces and it is still quite pissed at me , also I substantially decreased the size of a line and it is also still pissed at me , here let me link the line .
**Arabic list** compiled from personal contributions , as well as these sources :

EDIT 2 : WOW , finally !

@wooorm wooorm merged commit 1ad0501 into words:master Oct 13, 2018
@wooorm
Copy link
Member

wooorm commented Oct 13, 2018

@AhmedRedaAmin Landed!!

wooorm added a commit to words/profanities that referenced this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants