Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update houndci to support es6 #3326

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions .eslintrc.js

This file was deleted.

42 changes: 42 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"parser": "babel-eslint",
"env": {
"node": true,
"browser": true,
"jest/globals": true
},
"globals": {
"__DEV__": true
},
"plugins": [
"react",
"react-native",
"jest"
],
"extends": [
"plugin:@wordpress/eslint-plugin/recommended"
],
"settings": {
"import/resolver": {
"node": {
"moduleDirectory": [
"node_modules",
"gutenberg/node_modules"
]
}
}
},
"rules": {
// do not throw an error if imported dependencies are
// declared in `package.json` or `gutenberg/package.json`
"import/no-extraneous-dependencies": [
"error",
{
"packageDir" : [
".",
"./gutenberg/"
]
}
]
}
}
9 changes: 9 additions & 0 deletions .hound.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
javascript:
enabled: false
eslint:
enabled: true
Comment on lines +3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Hound documentation would imply we need to add a pointer to our own eslint configuration file. Did you find Hound worked without explicitly adding the path?

Suggested change
eslint:
enabled: true
eslint:
enabled: true
config_file: .eslintrc.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I am able to confirm either way.

config_file: .eslintrc.json
ignore_file: .eslintignore
swiftlint:
enabled: true
config_file: .swiftlint.yml
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {
* Internal dependencies
*/
import correctTextFontWeight from './text-font-weight-correct';
import setupJetpackEditor from './jetpack-editor-setup';
import initialHtml from './initial-html';
import setupJetpackEditor from './jetpack-editor-setup';

addAction( 'native.pre-render', 'gutenberg-mobile', () => {
require( './strings-overrides' );
Expand Down