Show the selected period on snapshot stats detail screens - #25918
Open
crazytonyli wants to merge 2 commits into
Open
Show the selected period on snapshot stats detail screens#25918crazytonyli wants to merge 2 commits into
crazytonyli wants to merge 2 commits into
Conversation
Formatting-only pass produced by the repository's swift-format hook on ReferrerStatsView, ExternalLinkStatsView, and ArchiveStatsView, committed separately to keep the subsequent change reviewable.
The Referrer, External Link, and Archive detail screens display a range-scoped views total, but nothing on screen states which period the number covers; the date range is frozen at push time and these screens have no fetch path, so they cannot host the interactive date range control. Add an optional dateInterval to StandaloneMetricView (used only by these three screens) that renders the formatted period as a secondary line under the value. The ReferrerStatsView preview mock now uses .last7Days so the preview exercises a date-style period label instead of a bare year. Part of CMM-2319.
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33860 | |
| Version | PR #25918 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | a0c8e18 | |
| Installation URL | 5bagthd6lfg9g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33860 | |
| Version | PR #25918 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | a0c8e18 | |
| Installation URL | 48tkdb4pm0av8 |
jkmassel
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/a8c/issue/CMM-2319.
The issue description is not accurate, because I misunderstood the chart. The date range control is visible at screen level (the first two screenshots in the Linear issue) and chart level (the third screenshot). What is not clear is some stats screens do not display the range.