App Intents: extract localizable strings from code at code freeze - #25766
Conversation
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33324 | |
| Version | PR #25766 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5778339 | |
| Installation URL | 66cp8br8u0jvg |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33324 | |
| Version | PR #25766 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5778339 | |
| Installation URL | 0ri26u720ht98 |
|
Version |
iOS 18 and later resolve the widget configuration UI's App Intents strings against the app bundle, whose GlotPress-managed Localizable.strings already carries the ios-widget. keys in every locale, so the static copies in the extension bundle only served iOS 17 (verified on 17.5/18.6/26.5 simulators, including that iOS 17 has no fallback to the app bundle). The iOS 17 user base no longer justifies maintaining 34 hand-refreshed translation snapshots, so its widget configuration UI now shows the English defaults.
|
@mokagio Thanks for the review! I decided to go with another direction. Keep the existing translations (there is only a couple), and reusing the WIP plural support translation pipeline (when its ready) for the new App Intents strings. With this direction, the existing apps work as it is, as long as we don't delete the existing translations. But we won't be able to translate new App Intents strings, until the plural support translation pipeline is ready. Again, this is for simplicity's sake. |
d523a8f to
5778339
Compare
mokagio
left a comment
There was a problem hiding this comment.
That means iOS 17 don't get the translated strings. I think this is an okay compromise, because we don't have many users on iOS 17 and we are going to drop it in two months.
Solid.


Description
Relates to #25753.
The deleted
Localizable.stringsfiles were added in #25753. They were added because, on iOS 17, the App Intents strings looks up the strings tables in the extension bundle, not the app bundle. But from iOS 18, they can look up from the app bundle. This discrepancy is validated on simulators. I'm not sure if that's the case on real devices too. I don't have an iOS 17 device.This PR simplified the localizable strings, by dropping the strings tables in the extension bundle (again, which is newly added in #25753). That means iOS 17 don't get the translated strings. I think this is an okay compromise, because we don't have many users on iOS 17 and we are going to drop it in two months.
To make sure the App Intents strings (used via
LocalizedStringResource) are translated, the code freeze now extracts theLocalizedStringResourcecall sites withxcstringstool(genstringscannot parse them) and merges them into the GlotPress upload.