Skip to content

Conversation

@crazytonyli
Copy link
Contributor

Note

This PR depends on #24776 and will be merged after it.

Description

Copy the WordPressKit library code to Modules/Sources/, without any changes. Only the Package.swift changes need to be reviewed.

@crazytonyli crazytonyli added this to the 26.3 milestone Sep 1, 2025
@crazytonyli crazytonyli requested a review from kean September 1, 2025 00:04
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 1, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number28736
VersionPR #24784
Bundle IDorg.wordpress.alpha
Commit12bf8fe
Installation URL7a2tji9a2rb4o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 1, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number28736
VersionPR #24784
Bundle IDcom.jetpack.alpha
Commit12bf8fe
Installation URL0o087isulomb8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I smoke-tested it – worked well 👍

Base automatically changed from wordpresskit-spm-unit-tests to trunk September 2, 2025 23:09
@crazytonyli crazytonyli force-pushed the wordpresskit-spm-source-code branch from 0651543 to 23b5802 Compare September 2, 2025 23:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@crazytonyli crazytonyli added this pull request to the merge queue Sep 3, 2025
Merged via the queue into trunk with commit 2015d78 Sep 3, 2025
29 of 32 checks passed
@crazytonyli crazytonyli deleted the wordpresskit-spm-source-code branch September 3, 2025 02:24
@sentry
Copy link

sentry bot commented Sep 13, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants