-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in a GIFAnimatedImage extension #24031
Conversation
Generated by 🚫 Danger |
@@ -185,7 +185,7 @@ extension GIFImageView { | |||
} | |||
} | |||
|
|||
public func prepareForReuse() { | |||
public func reset() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this code to an extension without realizing the method named prepareForReuse
already existed on GIFAnimatable
. There needs to be a more durable solution, but I fixed it like this for now.
The issue with the standard prepareForReuse
is that it only works for animated images, AFAIR.
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
* Fix crash in a GIFAnimatedImage extension (#24031) * Update WordPress metadata translations * Bump version number --------- Co-authored-by: Alex Grebenyuk <[email protected]>
Fixes #24030
To test:
Note: there are some existing issues with restart of animations on reload. I believe they've been there before.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: