-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Stock Photo and Tenor media sources when Jetpack features are removed #19826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
hassaanelgarem
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described 🚀
# Conflicts: # WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift
Same as mentioned in this comment, I'll solve the conflicts using the function UPDATE: Conflicts solved in 18662e1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the option to add media from Stock Photo (free photo library) and Tenor (free GIF library) sources when the Jetpack-powered features are removed.
Ref: pe7hp4-4k-p2
To test:
1 - StockPhoto and Tenor media sources ENABLED in WordPress app
Jetpack Features Removal Phase Four
andJetpack Features Removal Phase For New Users
flags off.2 - StockPhoto and Tenor media sources DISABLED in WordPress app
Jetpack Features Removal Phase Four
flag on.NOTE: It's recommended that the following steps are also checked by turning the
Jetpack Features Removal Phase For New Users
flag on andJetpack Features Removal Phase Four
flag off in Debug settings.3- StockPhoto and Tenor media sources ENABLED in Jetpack app
Jetpack Features Removal Phase Four
flag on. This flag should be omitted by the Jetpack app.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.