Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Stock Photo and Tenor media sources when Jetpack features are removed #19826

Merged
merged 7 commits into from
Jan 5, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 2, 2023

Disables the option to add media from Stock Photo (free photo library) and Tenor (free GIF library) sources when the Jetpack-powered features are removed.

Ref: pe7hp4-4k-p2

To test:

1 - StockPhoto and Tenor media sources ENABLED in WordPress app

  1. Navigate to App Settings in the WordPress app and open Debug settings.
  2. Turn Jetpack Features Removal Phase Four and Jetpack Features Removal Phase For New Users flags off.
  3. Navigate to the Media screen.
  4. Tap on the ➕ button to add media.
  5. Observe that the Free Photo Library and Free GIF Library options are available.
  6. Create/edit a post.
  7. Add an Image block and observe that different media source options are displayed.
  8. Observe that the Free Photo Library and Free GIF Library options are available.

2 - StockPhoto and Tenor media sources DISABLED in WordPress app

  1. Navigate to App Settings in the WordPress app and open Debug settings.
  2. Turn Jetpack Features Removal Phase Four flag on.

NOTE: It's recommended that the following steps are also checked by turning the Jetpack Features Removal Phase For New Users flag on and Jetpack Features Removal Phase Four flag off in Debug settings.

  1. Navigate to the Media screen.
  2. Tap on the ➕ button to add media.
  3. Observe that the Free Photo Library and Free GIF Library options are NOT available.
  4. Create/edit a post.
  5. Add an Image block and observe that different media source options are displayed.
  6. Observe that the Free Photo Library and Free GIF Library options are NOT available.

3- StockPhoto and Tenor media sources ENABLED in Jetpack app

  1. Navigate to App Settings in the Jetpack app and open Debug settings.
  2. Turn Jetpack Features Removal Phase Four flag on. This flag should be omitted by the Jetpack app.
  3. Navigate to the Media screen.
  4. Tap on the ➕ button to add media.
  5. Observe that the Free Photo Library and Free GIF Library options are available.
  6. Create/edit a post.
  7. Add an Image block and observe that different media source options are displayed.
  8. Observe that the Free Photo Library and Free GIF Library options are available.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added this to the 21.5 milestone Jan 2, 2023
@fluiddot fluiddot self-assigned this Jan 2, 2023
@fluiddot fluiddot marked this pull request as ready for review January 2, 2023 17:16
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 2, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19826-afde20f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 2, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19826-afde20f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@hassaanelgarem hassaanelgarem self-requested a review January 2, 2023 21:19
Copy link
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🚀

@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 3, 2023

Same as mentioned in this comment, I'll solve the conflicts using the function jetpackFeaturesEnabled().

UPDATE: Conflicts solved in 18662e1.

@fluiddot fluiddot merged commit 3e42498 into trunk Jan 5, 2023
@fluiddot fluiddot deleted the disable-jp-features-stock-photos-tenor branch January 5, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants