-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle stories media uploading post-publish #16445
Conversation
- Calls `mediaCoordinator.addMedia` instead of `uploadMedia` + observers. The `prepareToSave` method will handle all of this instead. - Removes all media upload references from the story specific APIs
This handles cases where media was added but uploaded before preparing to save. The `addMedia` method will immediately upload the post and references may need to be uploaded.
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
# Conflicts: # Podfile.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola @bjtitus 👋
Tested as described. I was able to select multiple media files, publish without a title, and see the uploading media status while viewing the drafts list.
There seems to some lag in several places: between selecting the media and rendering in the story editor and between responding to a tap of the arrow button and showing the spinner, but I don't see how that would be related to these changes.
from me.
Fixes #16054
Related PRs
Summary
Media Uploading
Changes the media upload process for stories to add media to the post through the existing
addMedia
method. Upon saving (and publishing) the post, the media references are updated if upload has completed or observed and then updated once complete.This prevents the case where media may not be uploaded by the time the Publish button was tapped, leading to a case where post status wasn't changed (due to an issue with media observers clashing).
Kanvas Loading States
The Kanvas updates improve the loading state handling for multiple export. The loading indicator should appear during export and hide once export is complete -- about the same time the Prepublishing Sheet is shown.
Upload.from.GitHub.for.iOS.MOV
Testing
Note: There is a known issue with text positioning which will be fixed separately.
Regression Notes
I'm not sure where to add automated tests for this.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.