Hide backup and scan activities from sites without backup access - #23218
Open
crazytonyli wants to merge 1 commit into
Open
Hide backup and scan activities from sites without backup access#23218crazytonyli wants to merge 1 commit into
crazytonyli wants to merge 1 commit into
Conversation
…ccess
WordPress.com backs up Simple sites internally and writes those events to
the activity log regardless of plan, so the activity endpoint returns
backup ("rewind") and scan activities even for sites whose plan does not
include those products. The web Activity Log excludes them by sending
not_group[]=rewind¬_group[]=scan when the site lacks the
backups-self-serve feature, but the apps never did, causing the mobile
Activity Log to show "Backup and scan complete" entries that the web
hides.
This mirrors the web behavior (getActivityLogHiddenGroups in wp-calypso):
a new GetActivityLogHiddenGroupsUseCase decides which groups to hide
based on the backups-self-serve plan feature, falling back to purchased
Jetpack backup/scan products for self-hosted sites, and the activity log
fetch passes them through a new notGroups field on FetchActivityLogPayload
so the server filters them out. The activity type filter picker removes
the hidden groups from its list so they cannot be selected, and the
Backup screen keeps showing rewind events since that is its purpose.
Collaborator
Contributor
|
|
Contributor
|
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Contributor
|
@crazytonyli Overall this looks good, but Claude found a few issues, and checks are failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicate wordpress-mobile/WordPress-iOS#25894