feat: process GutenbergKit media uploads per the app's media settings by dcalhoun · Pull Request #23142 · wordpress-mobile/WordPress-Android

dcalhoun · 2026-07-23T19:59:14Z

Description

Ref CMM-1249.

Device media picked in the GutenbergKit editor (the new, experimental block editor / NBE) currently uploads raw from the WebView straight to the WordPress REST API, bypassing the app's media settings that the legacy editor honors (image optimization/resizing, quality, EXIF location stripping, video optimization).

This PR integrates GutenbergKit's new MediaUploadDelegate (from GutenbergKit#357) so device uploads are processed natively per the app's media settings before upload, mirroring WordPress-iOS#25824. GutenbergKit runs a localhost relay server while the editor is open, hands each staged file to processFile, uploads via its default uploader, and relays WordPress's raw response to the editor verbatim — so attachment objects, media_details.sizes, blob-preview replacement, save-locking and error notices all behave exactly like a direct upload.

What `GBKMediaUploadProcessor.processFile` does (mirrors the iOS decision table, adapted to Android's pipeline)

Images — optimized via the existing WPMediaUtils.getOptimizedMedia (max dimension + quality from App Settings), with GPS EXIF stripped when the "Remove location" setting is on. The reported mime type/filename is corrected to the actual output format (non-PNG inputs, including HEIC, re-encode to JPEG). When processing would be a no-op (optimization off, no strip, no rotation), the original passes through untouched — no needless lossy re-encode.
Sideways-captured images — physically rotated for self-hosted sites when optimization is off (WP.com rotates server-side; parity with legacy, #5737).
GIFs — always pass through to preserve animation.
Videos — the free-plan 5-minute duration limit is always enforced; transcoding runs (via the existing WPVideoUtils/m4m path) only when the "Optimize videos" setting is on, keeping the transcoded file only when it's smaller than the original. Transcodes are serialized to bound codec/memory pressure. This matches Android's legacy behavior (where video optimization is opt-in), rather than iOS's always-transcode.
File types disallowed by the site plan (e.g. audio on free WP.com plans) are rejected up front with a localized message relayed to the editor as a notice.

The delegate is set unconditionally for the post/page GutenbergKit editor. If GutenbergKit's upload server fails to start, uploads degrade to the existing WebView path unchanged.

Testing instructions

All in the GutenbergKit editor (enable the experimental block editor for the site). Change settings between runs in App Settings → Media.

Image optimization:

With "Optimize images" on, insert a photo wider than the max-size setting (e.g. > 2000px).

Uploaded image is resized to the configured max dimension and is a JPEG.

Turn "Optimize images" off and "Remove location" off; insert a photo.

Uploaded bytes are identical to the original (no re-encode).

Location stripping:
3. Insert a JPEG, PNG, or WebP photo with GPS EXIF, with "Remove location" on (try both with optimization on and off).

The uploaded file has no GPS EXIF.

GIF:
4. Insert an animated GIF.

It uploads unchanged and still animates.

Video:
5. With "Optimize videos" on, insert a video wider than the width setting.

Uploaded video is a transcoded MP4 at the configured width.

Turn "Optimize videos" off; insert a video.

The original video uploads.

Disallowed type:

On a free WP.com site, insert a video or audio.

The editor shows a localized notice that the file type is disallowed.

dangermattic · 2026-07-23T19:59:41Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

wpmobilebot · 2026-07-23T20:01:09Z

Project dependencies changes

list

! Upgraded Dependencies
org.wordpress.gutenbergkit:android:trunk-16aceb17716dbef9fb2289d316e27dc812a569f6, (changed from v0.19.0)
org.wordpress:utils:156-2e542df55715dff22c21def058bea551ee9569d0, (changed from 3.14.0)

tree

 +--- project :libs:editor
-|    \--- org.wordpress.gutenbergkit:android:v0.19.0
+|    \--- org.wordpress.gutenbergkit:android:trunk-16aceb17716dbef9fb2289d316e27dc812a569f6
 +--- project :libs:fluxc
-|    \--- org.wordpress:utils:3.14.0
-|         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.24 (*)
-|         +--- org.apache.commons:commons-text:1.10.0 -> 1.15.0
-|         |    \--- org.apache.commons:commons-lang3:3.20.0
-|         +--- com.android.volley:volley:1.2.0 -> 1.2.1
-|         +--- com.google.android.material:material:1.2.1 -> 1.14.0 (*)
-|         +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 -> 1.2.0 (*)
-|         +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|         +--- org.greenrobot:eventbus:3.3.1 (*)
-|         \--- androidx.core:core-ktx:1.5.0 -> 1.16.0 (*)
+|    \--- org.wordpress:utils:156-2e542df55715dff22c21def058bea551ee9569d0
+|         +--- org.apache.commons:commons-text:1.10.0 -> 1.15.0
+|         |    \--- org.apache.commons:commons-lang3:3.20.0
+|         +--- com.google.android.material:material:1.2.1 -> 1.14.0 (*)
+|         +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 -> 1.2.0 (*)
+|         +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|         +--- org.greenrobot:eventbus:3.3.1 (*)
+|         +--- org.greenrobot:eventbus-java:3.3.1
+|         +--- androidx.core:core:1.5.0 -> 1.16.0 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.24 -> 2.4.10 (*)
-+--- org.wordpress:utils:{strictly 3.14.0} -> 3.14.0 (*)
++--- org.wordpress:utils:{strictly 156-2e542df55715dff22c21def058bea551ee9569d0} -> 156-2e542df55715dff22c21def058bea551ee9569d0 (*)
-\--- org.wordpress.gutenbergkit:android:v0.19.0 (*)
+\--- org.wordpress.gutenbergkit:android:trunk-16aceb17716dbef9fb2289d316e27dc812a569f6 (*)

wpmobilebot · 2026-07-23T20:09:10Z

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr23142-d70d4a0
	Build Number	`1498`
	Application ID	`org.wordpress.android.prealpha`
	Commit	`d70d4a0`
	Installation URL	6oojm00a3mpp0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-07-23T20:09:14Z

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr23142-d70d4a0
	Build Number	`1498`
	Application ID	`com.jetpack.android.prealpha`
	Commit	`d70d4a0`
	Installation URL	1ftfjjkihs19g

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-07-23T20:12:31Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

codecov · 2026-07-24T13:25:27Z

Codecov Report

❌ Patch coverage is 42.85714% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.81%. Comparing base (64302cb) to head (d70d4a0).
⚠️ Report is 7 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...android/ui/posts/editor/GBKMediaUploadProcessor.kt	45.88%	40 Missing and 6 partials ⚠️
.../org/wordpress/android/ui/prefs/AppPrefsWrapper.kt	0.00%	4 Missing ⚠️
...va/org/wordpress/android/util/MediaUtilsWrapper.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #23142   +/-   ##
=======================================
  Coverage   37.81%   37.81%           
=======================================
  Files        2343     2344    +1     
  Lines      127397   127488   +91     
  Branches    17681    17704   +23     
=======================================
+ Hits        48170    48209   +39     
- Misses      75271    75317   +46     
- Partials     3956     3962    +6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Consumes the snapshot build of wordpress-mobile/GutenbergKit#357, which adds the MediaUploadDelegate API for host-side media upload processing. To be swapped to a tagged release before merge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Adds video optimization and strip-image-location accessors to AppPrefsWrapper, and a stripImageLocation passthrough to MediaUtilsWrapper, so the upcoming GutenbergKit media upload processor can read settings and strip GPS EXIF through injectable, testable wrappers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Implements GutenbergKit's MediaUploadDelegate to process device media picked in the experimental block editor before upload, honoring the app's media settings the same way the legacy editor pipeline does: - Images are optimized per the max size/quality settings via WPMediaUtils.getOptimizedMedia, with GPS EXIF stripped when the strip-location setting is on, and the reported mime type/extension corrected to the actual output format (non-PNG inputs, including HEIC, re-encode to JPEG). - When processing would be a no-op, the original file passes through untouched, avoiding a needless lossy re-encode. - Sideways-captured images are rotated for self-hosted sites when optimization is off (WP.com rotates server-side; issue #5737). - GIFs always pass through to preserve animation. - Videos enforce the free-plan 5-minute duration limit and transcode via WPVideoUtils/m4m only when the optimize-video setting is on, keeping the transcoded file only when smaller than the original. Transcodes are serialized to bound codec/memory pressure. - File types disallowed by the site plan are rejected with a localized message relayed to the editor as a notice. Nothing wires the processor yet; that lands separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Adds JVM unit tests for the processor's decision table: optimized image output with corrected mime/extension (incl. HEIC to JPEG and PNG passthrough), no-op short-circuit, GPS stripping onto the optimized output and onto a copy when optimization is off, GIF passthrough, self-hosted orientation fix, plan-disallowed type and over-limit video rejections with localized messages, video passthrough when optimization is disabled, and same-path optimization results treated as unprocessed. Also adds a File-based isProhibitedVideoDuration overload to MediaUtilsWrapper so the processor avoids Uri.fromFile, keeping it testable on the JVM. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Sets the media upload delegate on GutenbergView so device media picked in the experimental block editor is processed per the app's media settings before upload. The fragment stores and forwards the delegate following the existing setNetworkRequestListener pattern (GutenbergView tolerates assignment before or after page load), and the activity constructs the processor with its SiteModel and injected wrappers. If GutenbergKit's upload server fails to start, uploads degrade to the existing WebView path unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Consumes the PR-build snapshot of WordPress-Utils-Android#156, which stops ImageUtils.getImageOrientation from logging a spurious "Volume data not found" error on every optimized upload staged in the app cache dir (GutenbergKit native media uploads). To be swapped to a tagged release once that PR merges. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

processVideo and processImage are guard-clause decision tables where early returns read clearer than nesting; suppress ReturnCount to match the existing house style rather than fragment the logic. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

EXIF_MIME_TYPES gated the copy-and-strip branch on formats that can carry GPS, but androidx ExifInterface.saveAttributes() can only rewrite JPEG, PNG, and WebP. The set omitted PNG (so location-bearing PNGs uploaded un-stripped, a regression vs. the legacy pipeline) and included HEIC/HEIF (where saveAttributes throws an IOException that stripLocation swallows, uploading a still-geotagged copy while appearing to honor the setting). Correct the set to {JPEG, PNG, WebP} and cover the PNG-stripped and HEIC-passthrough cases in the decision-table tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

transcodeVideo logs each caught exception via .message, so Detekt's SwallowedException never fires — only TooGenericExceptionCaught does (NullPointerException and Exception are both on its generic-names list). Trim the suppression to the rule that actually triggers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

GutenbergKit validates uploads in the WebView against the site's allowedMimeTypes (fetched from /wp-block-editor/v1/settings and cached on disk) before the request reaches this delegate, so it rejects most disallowed types with its own localized message first. Document that this app-side check is a fallback for the cache-miss/undefined-settings path and can over-reject when its static MimeTypes table is stricter than the server's cached list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

PR 357 merged as 016a00e5, and the review follow-up 561 ("harden the native media upload server") landed on top of it. Track trunk at 16aceb17 instead of the transient PR branch build, picking up 561's fixes: idle-based body reads so a steadily-streamed large upload is no longer failed on total duration, rejection of auth-exempt OPTIONS carrying a body, and cancellable reads so shutdown reaps an active connection. Still an untagged snapshot, so the TODO stays. v0.19.0 is tagged but predates both 357 and 561. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

GutenbergKit 561 made mediaUploadDelegate throw when assigned after the editor page starts loading: the delegate is captured once, in onPageStarted, and the setter now check()s !hasStartedLoading. The old setter started the upload server on assignment and re-synced window.GBKit into a loaded page, so a late set used to work. setMediaUploadDelegate pushed straight into a possibly-loaded view, which would now crash. Store the delegate only and let onCreateView be the single place it reaches the view, moved to immediately after the GutenbergView constructor — on the preloaded-dependencies fast path that constructor already kicks off the load. The ordering holds: FragmentPagerAdapter.instantiateItem defers its transaction to finishUpdate, so the activity's setMediaUploadDelegate call returns before onCreateView runs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

GutenbergKit 561 added handlesFile, a metadata-only gate consulted before the upload server materializes a request to a temp file. Declining relays the original body straight to WordPress. processFile returns Original for GIFs and non-media, so today those pay a full byte-for-byte copy only to reach the same passthrough. Decline them up front and skip the copy. Disallowed types are claimed rather than declined, so processFile still runs and throws the localized rejection. Declining would relay them to WordPress instead, spending a whole upload on a file the site's plan won't accept and replacing our message with the server's untranslated one. That matters because Gutenberg's own validateMimeTypeForUser early-returns when the cached allowedMimeTypes list is absent, leaving this check as the only validation on a cold cache. handlesFile is an optimization hint, not the enforcement point: it sees only the client-supplied mime type and filename, which can disagree with the file's bytes, so the plan check inside processFile stays authoritative. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Mirrors the existing processFile cases: GIF and non-media are declined so the temp copy is skipped, images and videos are claimed. The disallowed-type case pairs with "disallowed file type throws with localized message", which uses the same mime type — that test would stop reflecting reality if handlesFile ever declined non-media unconditionally, since processFile would no longer run for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

dcalhoun mentioned this pull request Jul 24, 2026

fix: read EXIF orientation directly for plain file paths wordpress-mobile/WordPress-Utils-Android#156

Draft

dcalhoun and others added 14 commits August 17, 2026 09:50

dcalhoun force-pushed the feat/process-gutenberg-kit-media-uploads branch from d70d4a0 to d6db8eb Compare August 17, 2026 13:57

Navigation Menu

Uh oh!

feat: process GutenbergKit media uploads per the app's media settings - #23142

feat: process GutenbergKit media uploads per the app's media settings#23142
dcalhoun wants to merge 14 commits into
trunkfrom
feat/process-gutenberg-kit-media-uploads

dcalhoun commented Jul 23, 2026 •

edited

Loading

Uh oh!

dangermattic commented Jul 23, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 23, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 23, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 23, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 23, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 24, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dcalhoun commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What GBKMediaUploadProcessor.processFile does (mirrors the iOS decision table, adapted to Android's pipeline)

Testing instructions

Uh oh!

dangermattic commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project dependencies changes

Uh oh!

wpmobilebot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Build Failure Analysis

Uh oh!

codecov Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dcalhoun commented Jul 23, 2026 •

edited

Loading

What `GBKMediaUploadProcessor.processFile` does (mirrors the iOS decision table, adapted to Android's pipeline)

dangermattic commented Jul 23, 2026 •

edited

Loading

wpmobilebot commented Jul 23, 2026 •

edited

Loading

wpmobilebot commented Jul 23, 2026 •

edited

Loading

wpmobilebot commented Jul 23, 2026 •

edited

Loading

wpmobilebot commented Jul 23, 2026 •

edited

Loading

codecov Bot commented Jul 24, 2026 •

edited

Loading